Implement syzygy_generators for lists of module elements
#4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HechtiDerLachs
force-pushed
the
standard_basis_error_message
branch
from
06d1ea2
to
1d102a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4204 +/- ##
=======================================
Coverage 84.59% 84.60%
=======================================
Files 631 631
Lines 84906 84929 +23
=======================================
+ Hits 71830 71853 +23
Misses 13076 13076
|
|
Did you check this this gives a different error message? As far as I see it will still crash in the |
HechtiDerLachs
commented
Oct 15, 2024
HechtiDerLachs
changed the title
syzygy_generators for lists of module elements
thofma
reviewed
Oct 16, 2024
thofma
reviewed
Oct 16, 2024
HechtiDerLachs
commented
Oct 16, 2024
HechtiDerLachs
commented
Oct 16, 2024
Co-authored-by: Tommy Hofmann <[email protected]>
HechtiDerLachs
force-pushed
the
standard_basis_error_message
branch
from
a293359
to
da98c6e
Compare
thofma
approved these changes
Oct 16, 2024
HechtiDerLachs
added a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Oct 30, 2024
…tem#4204) Co-authored-by: Tommy Hofmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #4203 until we have more standard basis methods implemented.